[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 4/4] qapi: Test name mangling of downstream e
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 4/4] qapi: Test name mangling of downstream extensions |
Date: |
Wed, 29 Apr 2015 09:45:48 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 04/29/2015 05:32 AM, Markus Armbruster wrote:
> Eric Blake <address@hidden> writes:
>
>> So that we don't regress in supporting downstream extensions, make
>> sure that our testsuite covers downstream naming choices in as many
>> places as possible.
>>
>> +{ 'command': '__org.qemu_x-command',
>> + 'data': { 'a': ['__org.qemu_x-Enum'], 'b': ['__org.qemu_x-Struct'],
>> + 'c': '__org.qemu_x-Union2', 'd': '__org.qemu_x-Alt' } }
>
> Can't say offhand whether 'returns' takes a separate path. If it does,
> we better test it here.
Good catch. I got lucky; no further tweaks needed to make it work.
>
> Since it can be fixed on top if it's necessary,
Since I'm spinning v3 anyways, I'll fold it in.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 1/4] qapi: Fix C identifiers generated for names containing '.', (continued)