[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/8] tls: require compiler support for __thread
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 1/8] tls: require compiler support for __thread |
Date: |
Wed, 29 Apr 2015 13:09:45 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 28/04/2015 23:04, Emilio G. Cota wrote:
>
> commit ad45e590025c1197a7aef5164e1ae174894b0969
> Author: Emilio G. Cota <address@hidden>
> Date: Tue Apr 28 16:54:44 2015 -0400
>
> configure: require __thread support
>
> The codebase doesn't build without __thread support.
> Formalise this requirement by adding a check for it in the
> configure script.
>
> Signed-off-by: Emilio G. Cota <address@hidden>
>
> diff --git a/configure b/configure
> index 6969f6f..3d6591f 100755
> --- a/configure
> +++ b/configure
> @@ -1549,6 +1549,17 @@ if test "$static" = "yes" ; then
> fi
> fi
>
> +# Unconditional check for compiler __thread support
> + cat > $TMPC << EOF
> +static __thread int tls_var;
> +int main(void) { return tls_var; }
> +EOF
> +
> +if ! compile_prog "-Werror" "" ; then
> + error_exit "Your compiler does not support the __thread specifier for " \
> + "Thread-Local Storage (TLS). Please upgrade to a version that does."
> +fi
> +
> if test "$pie" = ""; then
> case "$cpu-$targetos" in
> i386-Linux|x86_64-Linux|x32-Linux|i386-OpenBSD|x86_64-OpenBSD)
Yes, thanks. I'll include the patch in my next pull request.
Paolo