[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PULL 76/76] block: move I/O request proce
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [Qemu-block] [PULL 76/76] block: move I/O request processing to block/io.c |
Date: |
Wed, 29 Apr 2015 10:27:26 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 28.04.2015 um 19:15 hat Eric Blake geschrieben:
> On 04/28/2015 09:00 AM, Kevin Wolf wrote:
> > From: Stefan Hajnoczi <address@hidden>
> >
> > The block.c file has grown to over 6000 lines. It is time to split this
> > file so there are fewer conflicts and the code is easier to maintain.
> >
> > Extract I/O request processing code:
> > * Read
> > * Write
> > * Zero writes and making the image empty
> > * Flush
> > * Discard
> > * ioctl
> > * Tracked requests and queuing
> > * Throttling and copy-on-read
> > * Block status and allocated functions
> > * Refreshing block limits
> > * Reading/writing vmstate
> > * qemu_blockalign() and friends
> >
> > The patch simply moves code from block.c into block/io.c.
> >
> > Signed-off-by: Stefan Hajnoczi <address@hidden>
> > Signed-off-by: Kevin Wolf <address@hidden>
> > ---
> > block.c | 3394
> > +++++++--------------------------------------------
> > block/Makefile.objs | 2 +-
> > block/io.c | 2540 ++++++++++++++++++++++++++++++++++++++
> > 3 files changed, 2982 insertions(+), 2954 deletions(-)
> > create mode 100644 block/io.c
>
> Kevin, compare your diff to Stefan's:
>
> > ---
> > block.c | 2512
> > --------------------------------------------------
> > block/Makefile.objs | 2 +-
> > block/io.c | 2540
> > +++++++++++++++++++++++++++++++++++++++++++++++++++
> > 3 files changed, 2541 insertions(+), 2513 deletions(-)
> > create mode 100644 block/io.c
>
> The difference is that Stefan has done 'git config diff.algorithm
> patience', which makes for MUCH more legible diffs on a code motion
> patch. http://wiki.qemu.org/Contribute/SubmitAPatch mentions this as a
> hint for a nicer setup.
Indeed, it does. I used --patience for reviewing the patch but neglected
to add it when sending the pull request. That said, I don't think I
could have enabled it for a single patch, and I'm not sure if it's
universally better (if so, why wouldn't it be the default?)
> At any rate, you've already sent the pull request, so I'm probably too
> late; but for the record, here's why I would add:
> Reviewed-by: Eric Blake <address@hidden>
> when reviewing Stefan's version of the patch (the two versions give the
> same end result, but my review technique falls flat on Kevin's replay of
> the patch)
You could apply both series and diff the result if you wanted.
But this one was easy enough to review on my own (...famous last words?)
Kevin
pgpPfQNspJEE9.pgp
Description: PGP signature
- [Qemu-devel] [PULL 69/76] iotests: add incremental backup granularity tests, (continued)
- [Qemu-devel] [PULL 69/76] iotests: add incremental backup granularity tests, Kevin Wolf, 2015/04/28
- [Qemu-devel] [PULL 71/76] block/dmg: make it modular, Kevin Wolf, 2015/04/28
- [Qemu-devel] [PULL 70/76] block/mirror: Always call block_job_sleep_ns(), Kevin Wolf, 2015/04/28
- [Qemu-devel] [PULL 73/76] block: replace bdrv_states iteration with bdrv_next(), Kevin Wolf, 2015/04/28
- [Qemu-devel] [PULL 67/76] iotests: add simple incremental backup case, Kevin Wolf, 2015/04/28
- [Qemu-devel] [PULL 72/76] vmdk: Widen before shifting 32 bit header field, Kevin Wolf, 2015/04/28
- [Qemu-devel] [PULL 74/76] block: add bdrv_set_dirty()/bdrv_reset_dirty() to block_int.h, Kevin Wolf, 2015/04/28
- [Qemu-devel] [PULL 75/76] block: extract bdrv_setup_io_funcs(), Kevin Wolf, 2015/04/28
- [Qemu-devel] [PULL 76/76] block: move I/O request processing to block/io.c, Kevin Wolf, 2015/04/28
- [Qemu-devel] [PULL 66/76] iotests: add QMP event waiting queue, Kevin Wolf, 2015/04/28
- Re: [Qemu-devel] [PULL 00/76] Block patches, Peter Maydell, 2015/04/28