Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends

[Peter Maydell]

On 28 April 2015 at 14:13, Michael S. Tsirkin <address@hidden> wrote:
> The patches look correct to me too, but I want s390
> cleaned up so it does not include COMMON_FEATURES
> in 100 places, and I prefer merging it all together.

It seems a bit harsh to ask Shannon to do s390 cleanup when
he doesn't have any access to s390 guests or test cases...
Making S390 put COMMON_FEATURES in the right places seems
to me like a separate bit of s390-specific cleanup.

(The other cleanup we could do after this patchset would
be to just expand out the DEFINE_VIRTIO_NET/RNG/SCSI/etc_FEATURES
macros which are all now used in exactly one place. But
again I think that's separate and can be done later.)

thanks
-- PMM