[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH target-arm v4 11/16] char: cadence_uart: Split s
|
From: |
Peter Crosthwaite |
|
Subject: |
Re: [Qemu-devel] [PATCH target-arm v4 11/16] char: cadence_uart: Split state struct and type into header |
|
Date: |
Thu, 23 Apr 2015 17:20:54 -0700 |
On Thu, Apr 23, 2015 at 11:00 AM, Peter Maydell
<address@hidden> wrote:
> On 23 March 2015 at 11:05, Peter Crosthwaite
> <address@hidden> wrote:
>> To allow using the device with modern SoC programming conventions. The
>> state struct needs to be visible to embed the device in SoC containers.
>>
>> Reviewed-by: Alistair Francis <address@hidden>
>> Signed-off-by: Peter Crosthwaite <address@hidden>
>
> Non-standalone commit message body, header file needs copyright/license
> comment, include guard shouldn't have trailing _. Otherwise:
>
All fixed.
> Reviewed-by: Peter Maydell <address@hidden>
>
Thanks,
Regards,
Peter
> thanks
> -- PMM
>