[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/2] irq: add get_gsi callback
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 0/2] irq: add get_gsi callback |
Date: |
Thu, 23 Apr 2015 11:30:59 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 23/04/2015 10:49, Eric Auger wrote:
> This series introduces a new callback function in IRQState, named
> get_gsi_cb. It is supposed to be populated by the interrupt controller
> and its role is to convert the interrupt controller pin number into
> the global system interrupt (gsi) number. The gsi is used when setting
> irqfd up.
>
> With PCI there is a PCIINTxRoute bus lookup mechanism that enables to
> retrieve the gsi from the PCI host controller/bridge pin. The conversion
> is implemented by the PCI host controller. With platform devices, this
> conversion function is implemented by the interrupt controller.
>
> Besides the callback member, a setter is introduced. First user is
> arm_gic_kvm. A public function wraps the callback, qemu_irq_get_gsi.
>
> The first user of qemu_irq_get_gsi might be the VFIO platform device.
> This will come in the "KVM platform device passthrough" series.
I'm sorry, I cannot understand the point of this without seeing a user.
Why can't you just use a GHashTable? This mustn't be a hot path, since
VFIO does all the signalling in the kernel via irqfds.
Paolo
- [Qemu-devel] [PATCH 0/2] irq: add get_gsi callback, Eric Auger, 2015/04/23
- [Qemu-devel] [PATCH 1/2] irq: add get_gsi callback, Eric Auger, 2015/04/23
- [Qemu-devel] [PATCH 2/2] intc: arm_gic_kvm: set the get_gsi callback, Eric Auger, 2015/04/23
- Re: [Qemu-devel] [PATCH 0/2] irq: add get_gsi callback,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH 0/2] irq: add get_gsi callback, Eric Auger, 2015/04/23
- Re: [Qemu-devel] [PATCH 0/2] irq: add get_gsi callback, Paolo Bonzini, 2015/04/23
- Re: [Qemu-devel] [PATCH 0/2] irq: add get_gsi callback, Eric Auger, 2015/04/23
- Re: [Qemu-devel] [PATCH 0/2] irq: add get_gsi callback, Eric Auger, 2015/04/24
- Re: [Qemu-devel] [PATCH 0/2] irq: add get_gsi callback, Paolo Bonzini, 2015/04/24
- Re: [Qemu-devel] [PATCH 0/2] irq: add get_gsi callback, Eric Auger, 2015/04/24
- Re: [Qemu-devel] [PATCH 0/2] irq: add get_gsi callback, Paolo Bonzini, 2015/04/24
- Re: [Qemu-devel] [PATCH 0/2] irq: add get_gsi callback, Eric Auger, 2015/04/24
- Re: [Qemu-devel] [PATCH 0/2] irq: add get_gsi callback, Paolo Bonzini, 2015/04/24
- Re: [Qemu-devel] [PATCH 0/2] irq: add get_gsi callback, Eric Auger, 2015/04/24