qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 09/11] qmp: Add an implementation wrapper for


From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH v2 09/11] qmp: Add an implementation wrapper for qmp_drive_backup
Date: Fri, 17 Apr 2015 18:12:28 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0

On 27.03.2015 20:20, John Snow wrote:
We'd like to be able to specify the callback given to backup_start
manually in the case of transactions, so split apart qmp_drive_backup
into an implementation and a wrapper.

Switch drive_backup_prepare to use the new wrapper, but don't overload
the callback and closure yet.

Signed-off-by: John Snow <address@hidden>
---
  blockdev.c | 65 ++++++++++++++++++++++++++++++++++++++++++++------------------
  1 file changed, 46 insertions(+), 19 deletions(-)

Reviewed-by: Max Reitz <address@hidden>

The problem being that it relies on patch 8. I don't think being able to avoid a single forward declaration warrants moving half (or more...) of blockdev.c around, but I'm open to be convinced otherwise.

Max



reply via email to

[Prev in Thread] Current Thread [Next in Thread]