Re: [Qemu-devel] [PATCH] vhost: pass corrent log base to kernel

[Michael S. Tsirkin]

On Wed, Apr 15, 2015 at 12:06:42PM +0800, Wen Congyang wrote:
> Signed-off-by: Wen Congyang <address@hidden>
> ---
>  hw/virtio/vhost.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
> index 5a12861..4e334ca 100644
> --- a/hw/virtio/vhost.c
> +++ b/hw/virtio/vhost.c
> @@ -1060,7 +1060,7 @@ int vhost_dev_start(struct vhost_dev *hdev, 
> VirtIODevice *vdev)
>          hdev->log_size = vhost_get_log_size(hdev);
>          hdev->log = hdev->log_size ?
>              g_malloc0(hdev->log_size * sizeof *hdev->log) : NULL;
> -        r = hdev->vhost_ops->vhost_call(hdev, VHOST_SET_LOG_BASE, hdev->log);
> +        r = hdev->vhost_ops->vhost_call(hdev, VHOST_SET_LOG_BASE, 
> &hdev->log);
>          if (r < 0) {
>              r = -errno;
>              goto fail_log;

Wow that's a serious bug.
But your patch won't work correctly on 32 bit systems.
I'll send a fixed patch.
Thanks!

> -- 
> 2.1.0