Re: [Qemu-devel] [PATCH 2/2] target-i386: kvm: Disable KVM quirks

[Nadav Amit]

Paolo Bonzini <address@hidden> wrote:

> 
> 
> On 13/04/2015 01:32, Nadav Amit wrote:
>> +    if (kvm_check_extension(s, KVM_CAP_ENABLE_CAP_VM)) {
> 
> The right capability to check here is KVM_CAP_DISABLE_QUIRKS, not
> KVM_CAP_ENABLE_CAP_VM.
> 
> Paolo
> 
>> +        ret = kvm_vm_enable_cap(s, KVM_CAP_DISABLE_QUIRKS, 0,
>> +                                KVM_QUIRK_LINT0_DISABLED |
>> +                                KVM_QUIRK_CD_NW_CLEARED);
>> +        if (ret < 0) {
>> +            return ret;
>> +        }
>> +    }

Of course…
Do you want a v2 now, later (after 4.2), or would you change it yourself?

Thanks,
Nadav