Re: [Qemu-devel] [PATCH v4 16/20] hw/acpi/aml-build: Add aml_else() term

[Alex Bennée]

Shannon Zhao <address@hidden> writes:

> From: Shannon Zhao <address@hidden>
>
> Signed-off-by: Shannon Zhao <address@hidden>
> Signed-off-by: Shannon Zhao <address@hidden>

I was considering if the magic numbers should be defined somewhere but I
guess that is the point of the stub functions.

Reviewed-by: Alex Bennée <address@hidden>


> ---
>  hw/acpi/aml-build.c         | 7 +++++++
>  include/hw/acpi/aml-build.h | 1 +
>  2 files changed, 8 insertions(+)
>
> diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
> index 4f936f7..9b8b422 100644
> --- a/hw/acpi/aml-build.c
> +++ b/hw/acpi/aml-build.c
> @@ -626,6 +626,13 @@ Aml *aml_if(Aml *predicate)
>      return var;
>  }
>  
> +/* ACPI 1.0: 16.2.3 Operators: DefElse */
> +Aml *aml_else(void)
> +{
> +    Aml *var = aml_bundle(0xA1 /* ElseOp */, AML_PACKAGE);
> +    return var;
> +}
> +
>  /* ACPI 1.0b: 16.2.5.2 Named Objects Encoding: DefMethod */
>  Aml *aml_method(const char *name, int arg_count)
>  {
> diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h
> index 6b407d5..3901515 100644
> --- a/include/hw/acpi/aml-build.h
> +++ b/include/hw/acpi/aml-build.h
> @@ -206,6 +206,7 @@ Aml *aml_scope(const char *name_format, ...) 
> GCC_FMT_ATTR(1, 2);
>  Aml *aml_device(const char *name_format, ...) GCC_FMT_ATTR(1, 2);
>  Aml *aml_method(const char *name, int arg_count);
>  Aml *aml_if(Aml *predicate);
> +Aml *aml_else(void);
>  Aml *aml_package(uint8_t num_elements);
>  Aml *aml_buffer(void);
>  Aml *aml_resource_template(void);

-- 
Alex Bennée