qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 05/12 v9] linux-user/syscall.c: conditionalize s


From: Chen Gang
Subject: Re: [Qemu-devel] [PATCH 05/12 v9] linux-user/syscall.c: conditionalize syscalls which are not defined in tilegx
Date: Sat, 11 Apr 2015 04:57:52 +0800
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.6.0

On 4/10/15 05:46, Peter Maydell wrote:
> On 27 March 2015 at 10:53, Chen Gang <address@hidden> wrote:
>> For tilegx, several syscall macros are not supported, so switch them to
>> avoid building break.
>>
>> Signed-off-by: Chen Gang <address@hidden>
> 
>> +#ifdef TARGET_NR_getpgrp
>>      case TARGET_NR_getpgrp:
>>          ret = get_errno(getpgrp());
>>          break;
>>      case TARGET_NR_setsid:
>>          ret = get_errno(setsid());
>>          break;
>> +#endif
> 
> This looks wrong -- your ifdef for NR_getpgrp is covering
> the setsid syscall too.
> 

OK, thanks.


-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed



reply via email to

[Prev in Thread] Current Thread [Next in Thread]