Re: [Qemu-devel] [PATCH v2 3/4] target-i386: Register QOM properties for feature flags

[Andreas Färber]

Am 10.04.2015 um 10:21 schrieb Paolo Bonzini:
> On 10/04/2015 09:27, Igor Mammedov wrote:
>>> +    for (i = 0; names[i]; i++) {
>>> +        char *feat_name = names[i];
>>> +        feat2prop(feat_name);
>>> +        char *prop_name = g_strdup_printf("cpuid-%s", feat_name);
>>
>> BTW: I've remembered why we've chosen feat- vs. cpuid- prefix
>> it was to make CPU features platform neutral so that libvirt
>> would use the same prefix for x86, arm other targets.
> 
> Ok, that make sense, but if we want to make it platform-neutral, let's
> spell it "feature-" or remove the prefix altogether.
> 
> If we remove it, perhaps we could add a QOM property with the list of
> features?
> 
> But I don't want to bikeshed too much.

I had suggested a container sub-object for property grouping but Anthony
preferred a prefix.

Btw a suffix could work as well and would read more natural. QMP don't
sort alphabetically anyway.

Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)