Re: [Qemu-devel] [PATCH v4 13/20] hw/acpi/aml-build: Add ToUUID macro

[Shannon Zhao]

On 2015/4/9 21:22, Igor Mammedov wrote:
> On Fri, 3 Apr 2015 18:03:45 +0800
> Shannon Zhao <address@hidden> wrote:
> 
>> > From: Shannon Zhao <address@hidden>
>> > 
>> > Add ToUUID macro, this is useful for generating PCIe ACPI table.
>> > 
>> > Signed-off-by: Shannon Zhao <address@hidden>
>> > Signed-off-by: Shannon Zhao <address@hidden>
>> > ---
>> >  hw/acpi/aml-build.c         | 23 +++++++++++++++++++++++
>> >  include/hw/acpi/aml-build.h |  2 ++
>> >  2 files changed, 25 insertions(+)
>> > 
>> > diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
>> > index bd1713c..5a94fc9 100644
>> > --- a/hw/acpi/aml-build.c
>> > +++ b/hw/acpi/aml-build.c
>> > @@ -933,6 +933,29 @@ Aml *aml_qword_memory(AmlDecode dec, AmlMinFixed 
>> > min_fixed,
>> >                               addr_trans, len, flags);
>> >  }
>> >  
>> > +/*
>> > + * ACPI 3.0: 17.5.124 ToUUID (Convert String to UUID Macro)
>> > + * e.g. UUID: E5C937D0-3553-4d7a-9117-EA4D19C3434D
>> > + * call aml_touuid(0xE5C937D0, 0x3553, 0x4d7a, 0x9117, 0xEA4D19C3434D);
> hmm,                  ^^^^ that's definitely no string
> 
Yes, the args are not string. When I implemented this function I thought about 
this.
In order to make it simple, I use HEX here. If we have to use string, I could 
modify this.

-- 
Thanks,
Shannon