[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/6] target-i386: Register QOM properties for fe
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH 3/6] target-i386: Register QOM properties for feature flags |
Date: |
Wed, 8 Apr 2015 08:06:00 -0300 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, Apr 08, 2015 at 10:30:52AM +0200, Paolo Bonzini wrote:
>
>
> On 07/04/2015 22:46, Eduardo Habkost wrote:
> > This uses the feature name arrays to register "feat-*" QOM properties
> > for feature flags. This simply adds the properties so they can be
> > configured using -global, but doesn't change x86_cpu_parse_featurestr()
> > to use them yet.
>
> Out of curiosity, why the prefix? (Also, perhaps a prefix such as
> "cpuid-*" would be better since the property often only affects the
> cpuid leaves, rather than the availability of the feature itself).
The prefix exists to allow those properties to be easily identified by
software that doesn't know the full list of feature names (I even took
advantage of that on the x86-cpu-model-dump script).
About the reason for using the "feat-" prefix, the short answer is "it's
the prefix used in the last patch that implemented this (by Igor)". I
think the first suggestion was to use "f-", then we changed to
"feature-" or "feat-", and simply stayed using "feat-" in the last few
versions.
But I like the "cpuid-" suggestion and plan to use it on v2. Any
objections?
--
Eduardo
- [Qemu-devel] [PATCH 0/6] target-i386: Feature properties, sample script for -global/-readconfig, Eduardo Habkost, 2015/04/07
- [Qemu-devel] [PATCH 1/6] target-i386: Move error handling to end of x86_cpu_parse_featurestr(), Eduardo Habkost, 2015/04/07
- [Qemu-devel] [PATCH 2/6] target-i386: Remove underscores from feature names, Eduardo Habkost, 2015/04/07
- [Qemu-devel] [PATCH 3/6] target-i386: Register QOM properties for feature flags, Eduardo Habkost, 2015/04/07
- Re: [Qemu-devel] [PATCH 3/6] target-i386: Register QOM properties for feature flags, Igor Mammedov, 2015/04/08
- Re: [Qemu-devel] [PATCH 3/6] target-i386: Register QOM properties for feature flags, Eduardo Habkost, 2015/04/08
- Re: [Qemu-devel] [PATCH 3/6] target-i386: Register QOM properties for feature flags, Paolo Bonzini, 2015/04/08
- Re: [Qemu-devel] [PATCH 3/6] target-i386: Register QOM properties for feature flags, Igor Mammedov, 2015/04/08
- Re: [Qemu-devel] [PATCH 3/6] target-i386: Register QOM properties for feature flags, Eduardo Habkost, 2015/04/08
- Re: [Qemu-devel] [PATCH 3/6] target-i386: Register QOM properties for feature flags, Igor Mammedov, 2015/04/08
[Qemu-devel] [PATCH 4/6] target-i386: Make "level" and "xlevel" properties static, Eduardo Habkost, 2015/04/07
[Qemu-devel] [PATCH 5/6] target-i386: X86CPU::xlevel2 QOM property, Eduardo Habkost, 2015/04/07