[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 08/45] Return path: socket_writev_buffer: Blo
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v5 08/45] Return path: socket_writev_buffer: Block even on non-blocking fd's |
Date: |
Sun, 29 Mar 2015 11:03:07 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 29/03/2015 06:07, David Gibson wrote:
> On Sat, Mar 28, 2015 at 04:30:06PM +0100, Paolo Bonzini wrote:
>>
>>
>> On 25/02/2015 17:51, Dr. David Alan Gilbert (git) wrote:
>>> + if (err != EAGAIN) {
>>
>> if (err != EAGAIN && err != EWOULDBLOCK)
>
> I assume that's for the benefit of non-Linux hosts? On Linux
> EAGAIN == EWOULDBLOCK.
Yes, that's just the standard idiom in QEMU. This is generic code, so
assumption based on the host platform are not wise. :)
Paolo