qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/2] spapr: populate ibm,loc-code


From: Nikunj A Dadhania
Subject: Re: [Qemu-devel] [PATCH 2/2] spapr: populate ibm,loc-code
Date: Fri, 27 Mar 2015 11:51:58 +0530
User-agent: Notmuch/0.17+27~gae47d61 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-redhat-linux-gnu)

Alexey Kardashevskiy <address@hidden> writes:

>> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
>> index 95d666e..dd97258 100644
>> --- a/hw/vfio/pci.c
>> +++ b/hw/vfio/pci.c
>> @@ -3319,6 +3319,24 @@ static void 
>> vfio_unregister_req_notifier(VFIOPCIDevice *vdev)
>>       vdev->req_enabled = false;
>>   }
>>
>> +bool vfio_get_devspec(PCIDevice *pdev, char **value)
>
>
> This function can live in hw/ppc/spapr_pci_vfio.c. Something like 
> object_property_get_str(OBJECT(pdev), "host", NULL) will return the host 
> address, and this is all you really want from VFIO here.

Looking more deeper, "host" is part of VFIOPCIDevice, which is not
available in hw/pci/spapr_pci_vfio.c

This was the reason, I had to move this code to hw/vfio/pci.c

Is there a way to get that?

Regards
Nikunj




reply via email to

[Prev in Thread] Current Thread [Next in Thread]