[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-discuss] error - Guest has not initialized the di
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [Qemu-discuss] error - Guest has not initialized the display yet. |
Date: |
Thu, 26 Mar 2015 20:55:12 +0000 |
On 26 March 2015 at 20:31, Mark Cave-Ayland
<address@hidden> wrote:
> I've just done some testing here and I see exactly the same issue -
> something is preventing OpenBIOS from executing. A quick session with
> git bisect points to the following:
>
>
> c3c1bb99d1c11978d9ce94d1bdcf0705378c1459 is the first bad commit
> commit c3c1bb99d1c11978d9ce94d1bdcf0705378c1459
> Author: Peter Crosthwaite <address@hidden>
> Date: Mon Mar 16 22:35:54 2015 -0700
>
> exec: Respect as_tranlsate_internal length clamp
>
> address_space_translate_internal will clamp the *plen length argument
> based on the size of the memory region being queried. The iommu walker
> logic in addresss_space_translate was ignoring this by discarding the
> post fn call value of *plen. Fix by just always using *plen as the
> length argument throughout the fn, removing the len local variable.
>
> This fixes a bootloader bug when a single elf section spans multiple
> QEMU memory regions.
>
> Signed-off-by: Peter Crosthwaite <address@hidden>
> Message-Id:
> <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
>
>
> Reproduction is easy with the command line given below:
>
> ./qemu-system-ppc -prom-env 'auto-boot?=false'
I feel like we're recapitulating history here -- is
c3c1bb99d undoing the fix that a87f39543a made for when we
tried this a year ago in 360e607, or is there something
more subtle going on ?
-- PMM