[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v2 15/23] ppc: Move cpu_exec_init() call to
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [RFC PATCH v2 15/23] ppc: Move cpu_exec_init() call to realize function |
Date: |
Wed, 25 Mar 2015 14:25:09 +1100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Mar 23, 2015 at 07:05:56PM +0530, Bharata B Rao wrote:
> Move cpu_exec_init() call from instance_init to realize. This allows
> any failures from cpu_exec_init() to be handled appropriately.
>
> Also add cpu_exec_exit() call from unrealize.
This still leaves all non-ppc archs not ever calling cpu_exec_exit().
>
> Signed-off-by: Bharata B Rao <address@hidden>
> ---
> target-ppc/translate_init.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
> index 9f4f172..fccee82 100644
> --- a/target-ppc/translate_init.c
> +++ b/target-ppc/translate_init.c
> @@ -8928,6 +8928,11 @@ static void ppc_cpu_realizefn(DeviceState *dev, Error
> **errp)
> return;
> }
>
> + cpu_exec_init(&cpu->env, &local_err);
> + if (local_err != NULL) {
> + error_propagate(errp, local_err);
> + return;
> + }
> cpu->cpu_dt_id = (cs->cpu_index / smp_threads) * max_smt
> + (cs->cpu_index % smp_threads);
> #endif
> @@ -9141,6 +9146,8 @@ static void ppc_cpu_unrealizefn(DeviceState *dev, Error
> **errp)
> opc_handler_t **table;
> int i, j;
>
> + cpu_exec_exit(CPU(dev));
> +
> for (i = 0; i < PPC_CPU_OPCODES_LEN; i++) {
> if (env->opcodes[i] == &invalid_handler) {
> continue;
> @@ -9679,8 +9686,6 @@ static void ppc_cpu_initfn(Object *obj)
> CPUPPCState *env = &cpu->env;
>
> cs->env_ptr = env;
> - cpu_exec_init(env, NULL);
> - cpu->cpu_dt_id = cs->cpu_index;
>
> env->msr_mask = pcc->msr_mask;
> env->mmu_model = pcc->mmu_model;
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
pgpOsq2mRz3Qc.pgp
Description: PGP signature
- Re: [Qemu-devel] [RFC PATCH v2 12/23] spapr: CPU hotplug support, (continued)
- [Qemu-devel] [RFC PATCH v2 13/23] cpus: Add Error argument to cpu_exec_init(), Bharata B Rao, 2015/03/23
- [Qemu-devel] [RFC PATCH v2 15/23] ppc: Move cpu_exec_init() call to realize function, Bharata B Rao, 2015/03/23
- Re: [Qemu-devel] [RFC PATCH v2 15/23] ppc: Move cpu_exec_init() call to realize function,
David Gibson <=
- [Qemu-devel] [RFC PATCH v2 14/23] cpus: Convert cpu_index into a bitmap, Bharata B Rao, 2015/03/23
- [Qemu-devel] [RFC PATCH v2 16/23] cpus: Reclaim vCPU objects, Bharata B Rao, 2015/03/23
- [Qemu-devel] [RFC PATCH v2 17/23] xics_kvm: Don't enable KVM_CAP_IRQ_XICS if already enabled, Bharata B Rao, 2015/03/23