[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 3/9] uninorth: convert ffs(3) to ctz32()
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH v3 3/9] uninorth: convert ffs(3) to ctz32() |
Date: |
Mon, 23 Mar 2015 15:29:25 +0000 |
It is not clear from the code how a 0 parameter should be handled by the
hardware. Keep the same behavior as ffs(0) - 1 == -1.
Cc: Alexander Graf <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
hw/pci-host/uninorth.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/pci-host/uninorth.c b/hw/pci-host/uninorth.c
index 53f2b59..f0144eb 100644
--- a/hw/pci-host/uninorth.c
+++ b/hw/pci-host/uninorth.c
@@ -92,7 +92,10 @@ static uint32_t unin_get_config_reg(uint32_t reg, uint32_t
addr)
uint32_t slot, func;
/* Grab CFA0 style values */
- slot = ffs(reg & 0xfffff800) - 1;
+ slot = ctz32(reg & 0xfffff800);
+ if (slot == 32) {
+ slot = -1; /* XXX: should this be 0? */
+ }
func = (reg >> 8) & 7;
/* ... and then convert them to x86 format */
--
2.1.0
- [Qemu-devel] [PATCH v3 0/9] Convert ffs(3) to ctz32(), Stefan Hajnoczi, 2015/03/23
- [Qemu-devel] [PATCH v3 1/9] bt-sdp: fix broken uuids power-of-2 calculation, Stefan Hajnoczi, 2015/03/23
- [Qemu-devel] [PATCH v3 3/9] uninorth: convert ffs(3) to ctz32(),
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH v3 2/9] hw/arm/nseries: convert ffs(3) to ctz32(), Stefan Hajnoczi, 2015/03/23
- [Qemu-devel] [PATCH v3 7/9] omap_intc: convert ffs(3) to ctz32() in omap_inth_sir_update(), Stefan Hajnoczi, 2015/03/23
- [Qemu-devel] [PATCH v3 6/9] sd: convert sd_normal_command() ffs(3) call to ctz32(), Stefan Hajnoczi, 2015/03/23
- [Qemu-devel] [PATCH v3 9/9] checkpatch: complain about ffs(3) calls, Stefan Hajnoczi, 2015/03/23
- [Qemu-devel] [PATCH v3 4/9] Convert (ffs(val) - 1) to ctz32(val), Stefan Hajnoczi, 2015/03/23
- [Qemu-devel] [PATCH v3 5/9] Convert ffs() != 0 callers to ctz32(), Stefan Hajnoczi, 2015/03/23
- [Qemu-devel] [PATCH v3 8/9] os-win32: drop ffs(3) prototype, Stefan Hajnoczi, 2015/03/23
- Re: [Qemu-devel] [PATCH v3 0/9] Convert ffs(3) to ctz32(), Stefan Hajnoczi, 2015/03/25