Re: [Qemu-devel] [PATCH v3 5/5] fw_cfg: insert fw_cfg file blobs via qemu cmdline

[Laszlo Ersek]

On 03/23/15 14:19, Gabriel L. Somlo wrote:
> On Mon, Mar 23, 2015 at 09:48:52AM +0100, Laszlo Ersek wrote:
>>
>>> diff --git a/qemu-options.hx b/qemu-options.hx
>>> index 319d971..138b9cd 100644
>>> --- a/qemu-options.hx
>>> +++ b/qemu-options.hx
>>> @@ -2668,6 +2668,17 @@ STEXI
>>>  @table @option
>>>  ETEXI
>>>  
>>> +DEF("fw_cfg", HAS_ARG, QEMU_OPTION_fwcfg,
>>> +    "-fw_cfg name=<name>,file=<file>\n"
>>
>> I guess I should have pointed this out earlier -- you could have
>> bracketed the "name=" part, to communicate that "name" is
>> "implied_opt_name".
>>
>> Anyway, don't respin just because of this.
> 
> Well, this *should* go in, aesthetics are important to me too :)
> If I get more feedback, I'll work this into a v4 of the series.
> 
> However, if this is it, and everything is OK otherwise, what's the
> standard procedure for fixing just this one minor item ? Do I still
> send out a v4, or is this something the maintainer ultimately applying
> the patch would rather do themselves ?

Depends on the exact maintainer picking up your series.

... Now good luck figuring out who that's going to be :)

(I ran "scripts/get_maintainer.pl" on a squashed diff for this series.
It named only Paolo, but for the wrong reason: "vl.c" matched "Main
loop" from the MAINTAINERS file. fw_cfg has no dedicated owner, apparently.)

Thanks
Laszlo