[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 1/6] numa: Fix off-by-one error at MAX_CPUMASK_BITS c
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [PULL 1/6] numa: Fix off-by-one error at MAX_CPUMASK_BITS check |
Date: |
Thu, 19 Mar 2015 16:26:09 -0300 |
Fix the CPU index check to ensure we don't go beyond the size of the
node_cpu bitmap.
CPU index is always less than MAX_CPUMASK_BITS, as documented at
sysemu.h:
> The following shall be true for all CPUs:
> cpu->cpu_index < max_cpus <= MAX_CPUMASK_BITS
Reviewed-by: Igor Mammedov <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
---
numa.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/numa.c b/numa.c
index ffbec68..13b2f01 100644
--- a/numa.c
+++ b/numa.c
@@ -76,9 +76,9 @@ static void numa_node_parse(NumaNodeOptions *node, QemuOpts
*opts, Error **errp)
}
for (cpus = node->cpus; cpus; cpus = cpus->next) {
- if (cpus->value > MAX_CPUMASK_BITS) {
+ if (cpus->value >= MAX_CPUMASK_BITS) {
error_setg(errp, "CPU number %" PRIu16 " is bigger than %d",
- cpus->value, MAX_CPUMASK_BITS);
+ cpus->value, MAX_CPUMASK_BITS - 1);
return;
}
bitmap_set(numa_info[nodenr].node_cpu, cpus->value, 1);
--
2.1.0
- [Qemu-devel] [PULL 0/6] NUMA queue 2015-03-19, Eduardo Habkost, 2015/03/19
- [Qemu-devel] [PULL 1/6] numa: Fix off-by-one error at MAX_CPUMASK_BITS check,
Eduardo Habkost <=
- [Qemu-devel] [PULL 4/6] numa: introduce machine callback for VCPU to node mapping, Eduardo Habkost, 2015/03/19
- [Qemu-devel] [PULL 2/6] numa: Reject CPU indexes > max_cpus, Eduardo Habkost, 2015/03/19
- [Qemu-devel] [PULL 6/6] numa: Print warning if no node is assigned to a CPU, Eduardo Habkost, 2015/03/19
- [Qemu-devel] [PULL 3/6] numa: Reject configuration if CPU appears on multiple nodes, Eduardo Habkost, 2015/03/19
- [Qemu-devel] [PULL 5/6] pc: fix default VCPU to NUMA node mapping, Eduardo Habkost, 2015/03/19
- Re: [Qemu-devel] [PULL 0/6] NUMA queue 2015-03-19, Peter Maydell, 2015/03/20