Re: [Qemu-devel] [PATCH 1/1] virtio: serial: expose a 'guest_writable' callback for users

[Peter Maydell]

On 19 March 2015 at 11:03, Amit Shah <address@hidden> wrote:
> On (Thu) 19 Mar 2015 [11:21:04], Markus Armbruster wrote:
>> Amit Shah <address@hidden> writes:
>>
>> > +         * This is dependent on both, the guest and host ends being
>> > +         * connected.
>>
>> Sounds awkward.  Perhaps: This is dependent on both the guest and
>> thehost end being connected.
>
> or an added comma?

No, I think extra commas would make things worse :-) I like
Markus' phrasing.

>  I think it can go in later as a cleanup if this
> patch goes in; I already sent pull req before seeing this mail..

I would prefer you just reroll the pullreq. You won't miss
the rc1 boat (that's not til next week).

thanks
-- PMM