[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/3] uhci: fix segfault when hot-unplugging u
|
From: |
Gonglei |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 1/3] uhci: fix segfault when hot-unplugging uhci controller |
|
Date: |
Wed, 18 Mar 2015 15:55:42 +0800 |
|
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 2015/3/18 15:35, Markus Armbruster wrote:
> Gerd Hoffmann <address@hidden> writes:
>
>> Hi,
>>
>>> -static void uhci_reset(void *opaque)
>>> +static void uhci_reset(DeviceState *dev)
>>> {
>>> - UHCIState *s = opaque;
>>> + PCIDevice *d = PCI_DEVICE(dev);
>>> + UHCIState *s = DO_UPCAST(UHCIState, dev, d);
>>
>> Uh, oh, DO_UPCAST() is long deprecated. There are other instances of
> [...]
>
> Only 378 instances left in the code %-}
>
Maybe I can do some cleanup work for 2.4 ;)
Regards,
-Gonglei