Re: [Qemu-devel] [PATCH v2 1/7] migration: Remove unused functions

[Juan Quintela]

Thomas Huth <address@hidden> wrote:
> migrate_rdma_pin_all(), qsb_clone() and qsb_set_length()
> are completely unused and thus can be deleted.
>
> Signed-off-by: Thomas Huth <address@hidden>
> Cc: Juan Quintela <address@hidden>
> Cc: Amit Shah <address@hidden>
>  void migrate_del_blocker(Error *reason);
>  
> -bool migrate_rdma_pin_all(void);

Removed


> diff --git a/include/migration/qemu-file.h b/include/migration/qemu-file.h
> index a923cec..45d7f71 100644
> --- a/include/migration/qemu-file.h
> +++ b/include/migration/qemu-file.h
> @@ -133,9 +133,7 @@ bool qemu_file_mode_is_not_valid(const char *mode);
>  bool qemu_file_is_writable(QEMUFile *f);
>  
>  QEMUSizedBuffer *qsb_create(const uint8_t *buffer, size_t len);
> -QEMUSizedBuffer *qsb_clone(const QEMUSizedBuffer *);

Removed


>  void qsb_free(QEMUSizedBuffer *);
> -size_t qsb_set_length(QEMUSizedBuffer *qsb, size_t length);

Being used in the COLO patches (posted on the list)

Adjusted the removal by hand, thanks.

Applied, thanks.