[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 1/5] exec: Atomic access to bounce buffer
From: |
Fam Zheng |
Subject: |
[Qemu-devel] [PATCH v4 1/5] exec: Atomic access to bounce buffer |
Date: |
Mon, 16 Mar 2015 17:03:33 +0800 |
There could be a race condition when two processes call
address_space_map concurrently and both want to use the bounce buffer.
Add an in_use flag in BounceBuffer to sync it.
Signed-off-by: Fam Zheng <address@hidden>
---
exec.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/exec.c b/exec.c
index e97071a..8d21eff 100644
--- a/exec.c
+++ b/exec.c
@@ -2483,6 +2483,7 @@ typedef struct {
void *buffer;
hwaddr addr;
hwaddr len;
+ bool in_use;
} BounceBuffer;
static BounceBuffer bounce;
@@ -2571,7 +2572,7 @@ void *address_space_map(AddressSpace *as,
l = len;
mr = address_space_translate(as, addr, &xlat, &l, is_write);
if (!memory_access_is_direct(mr, is_write)) {
- if (bounce.buffer) {
+ if (atomic_xchg(&bounce.in_use, true)) {
return NULL;
}
/* Avoid unbounded allocations */
@@ -2641,6 +2642,7 @@ void address_space_unmap(AddressSpace *as, void *buffer,
hwaddr len,
qemu_vfree(bounce.buffer);
bounce.buffer = NULL;
memory_region_unref(bounce.mr);
+ atomic_mb_set(&bounce.in_use, false);
cpu_notify_map_clients();
}
--
1.9.3
- [Qemu-devel] [PATCH v4 0/5] exec: Make bounce buffer thread safe, Fam Zheng, 2015/03/16
- [Qemu-devel] [PATCH v4 3/5] exec: Protect map_client_list with mutex, Fam Zheng, 2015/03/16
- [Qemu-devel] [PATCH v4 1/5] exec: Atomic access to bounce buffer,
Fam Zheng <=
- [Qemu-devel] [PATCH v4 2/5] linux-user, bsd-user: Remove two calls to cpu_exec_init_all, Fam Zheng, 2015/03/16
- [Qemu-devel] [PATCH v4 4/5] exec: Notify cpu_register_map_client caller if the bounce buffer is available, Fam Zheng, 2015/03/16
- [Qemu-devel] [PATCH v4 5/5] dma-helpers: Fix race condition of continue_after_map_failure and dma_aio_cancel, Fam Zheng, 2015/03/16