[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3] vl: fix resource leak with monitor_fdset_add_fd
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH v3] vl: fix resource leak with monitor_fdset_add_fd |
Date: |
Sun, 15 Mar 2015 10:16:28 +0100 |
monitor_fdset_add_fd returns an AddfdInfo struct (used by the QMP
command add_fd). Free it.
Signed-off-by: Paolo Bonzini <address@hidden>
---
v1->v2: line length [Fam], pass &error_abort [Shannon]
v2->v3: use "!!" instead of "? true : false" [Markus]
---
vl.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/vl.c b/vl.c
index eba5d4c..5985680 100644
--- a/vl.c
+++ b/vl.c
@@ -1011,6 +1011,7 @@ static int parse_add_fd(QemuOpts *opts, void *opaque)
int fd, dupfd, flags;
int64_t fdset_id;
const char *fd_opaque = NULL;
+ AddfdInfo *fdinfo;
fd = qemu_opt_get_number(opts, "fd", -1);
fdset_id = qemu_opt_get_number(opts, "set", -1);
@@ -1060,8 +1061,9 @@ static int parse_add_fd(QemuOpts *opts, void *opaque)
}
/* add the duplicate fd, and optionally the opaque string, to the fd set */
- monitor_fdset_add_fd(dupfd, true, fdset_id, fd_opaque ? true : false,
- fd_opaque, NULL);
+ fdinfo = monitor_fdset_add_fd(dupfd, true, fdset_id, !!fd_opaque,
fd_opaque,
+ &error_abort);
+ g_free(fdinfo);
return 0;
}
--
2.3.0
- [Qemu-devel] [PATCH v3] vl: fix resource leak with monitor_fdset_add_fd,
Paolo Bonzini <=