[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] block: Fix block-set-write-threshold not to use fun
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH] block: Fix block-set-write-threshold not to use funky error class |
Date: |
Fri, 13 Mar 2015 18:51:38 +0100 |
Error classes are a leftover from the days of "rich" error objects.
New code should always use ERROR_CLASS_GENERIC_ERROR. Commit e246211
added a use of ERROR_CLASS_DEVICE_NOT_FOUND. Replace it.
Signed-off-by: Markus Armbruster <address@hidden>
---
block/write-threshold.c | 2 +-
qapi/block-core.json | 4 ----
2 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/block/write-threshold.c b/block/write-threshold.c
index c2cd517..a53c1f5 100644
--- a/block/write-threshold.c
+++ b/block/write-threshold.c
@@ -112,7 +112,7 @@ void qmp_block_set_write_threshold(const char *node_name,
bs = bdrv_find_node(node_name);
if (!bs) {
- error_set(errp, QERR_DEVICE_NOT_FOUND, node_name);
+ error_setg(errp, "Device '%s' not found", node_name);
return;
}
diff --git a/qapi/block-core.json b/qapi/block-core.json
index 90586a5..42c8850 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -1961,10 +1961,6 @@
# @write-threshold: configured threshold for the block device, bytes.
# Use 0 to disable the threshold.
#
-# Returns: Nothing on success
-# If @node name is not found on the block device graph,
-# DeviceNotFound
-#
# Since: 2.3
##
{ 'command': 'block-set-write-threshold',
--
1.9.3
- [Qemu-devel] [PATCH] block: Fix block-set-write-threshold not to use funky error class,
Markus Armbruster <=