[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 8/9] memory: Move owner-less MemoryRegions to
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2 8/9] memory: Move owner-less MemoryRegions to /machine/unattached |
Date: |
Thu, 12 Mar 2015 19:05:10 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 12/03/2015 17:43, Andreas Färber wrote:
> This cleans up the official /machine namespace. In particular
> /machine/system and /machine/io as well as entries with non-sanitized
> node names.
Just a question: isn't it /machine/system[0] and /machine/io[0]?
>
> Cc: Paolo Bonzini <address@hidden>
> Signed-off-by: Andreas Färber <address@hidden>
> ---
> memory.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/memory.c b/memory.c
> index 20f6d9e..ee3f2a8 100644
> --- a/memory.c
> +++ b/memory.c
> @@ -868,7 +868,7 @@ void memory_region_init(MemoryRegion *mr,
> uint64_t size)
> {
> if (!owner) {
> - owner = qdev_get_machine();
> + owner = container_get(qdev_get_machine(), "/unattached");
> }
>
> object_initialize(mr, sizeof(*mr), TYPE_MEMORY_REGION);
>
Acked-by: Paolo Bonzini <address@hidden>
- Re: [Qemu-devel] [PATCH v2 3/9] qom: Implement qom-set HMP command, (continued)
- [Qemu-devel] [PATCH v2 5/9] qapi: Stub out StringOutputVisitor struct support, Andreas Färber, 2015/03/12
- [Qemu-devel] [PATCH v2 4/9] qom: Implement info qom-tree HMP command, Andreas Färber, 2015/03/12
- [Qemu-devel] [PATCH v2 9/9] qdev: Move owner-less IRQs to /machine/unattached, Andreas Färber, 2015/03/12
- [Qemu-devel] [PATCH v2 2/9] qom: Implement qom-list HMP command, Andreas Färber, 2015/03/12
- [Qemu-devel] [PATCH v2 7/9] qom: Add verbose option to info qom-tree HMP command, Andreas Färber, 2015/03/12
- [Qemu-devel] [PATCH v2 6/9] qom: Implement qom-get HMP command, Andreas Färber, 2015/03/12
- [Qemu-devel] [PATCH v2 8/9] memory: Move owner-less MemoryRegions to /machine/unattached, Andreas Färber, 2015/03/12
- Re: [Qemu-devel] [PATCH v2 8/9] memory: Move owner-less MemoryRegions to /machine/unattached,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH v2 0/9] qom: HMP commands to supersede info qtree, Gonglei, 2015/03/12
- Re: [Qemu-devel] [PATCH v2 0/9] qom: HMP commands to supersede info qtree, Markus Armbruster, 2015/03/17
- Re: [Qemu-devel] [PATCH v2 0/9] qom: HMP commands to supersede info qtree, Andreas Färber, 2015/03/17