[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 5/5] usb/dev-storage: Avoid qerror_report_err() outs
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH 5/5] usb/dev-storage: Avoid qerror_report_err() outside QMP handlers |
Date: |
Thu, 12 Mar 2015 17:26:50 +0100 |
qerror_report_err() is a transitional interface to help with
converting existing monitor commands to QMP. It should not be used
elsewhere.
usb_msd_password_cb() is only called from within an HMP command
handler. Replace by error_report_err().
Signed-off-by: Markus Armbruster <address@hidden>
---
hw/usb/dev-storage.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c
index f50bcb8..ae8d40d 100644
--- a/hw/usb/dev-storage.c
+++ b/hw/usb/dev-storage.c
@@ -559,8 +559,7 @@ static void usb_msd_password_cb(void *opaque, int err)
}
if (local_err) {
- qerror_report_err(local_err);
- error_free(local_err);
+ error_report_err(local_err);
qdev_unplug(&s->dev.qdev, NULL);
}
}
--
1.9.3
- [Qemu-devel] [PATCH 0/5] monitor usb: Fixes for encrypted images, Markus Armbruster, 2015/03/12
- [Qemu-devel] [PATCH 2/5] monitor: Plug memory leak in monitor_read_bdrv_key_start(), Markus Armbruster, 2015/03/12
- [Qemu-devel] [PATCH 5/5] usb/dev-storage: Avoid qerror_report_err() outside QMP handlers,
Markus Armbruster <=
- [Qemu-devel] [PATCH 4/5] usb/dev-storage: Fix QMP device_add missing encryption key failure, Markus Armbruster, 2015/03/12
- [Qemu-devel] [PATCH 1/5] monitor: Drop dead QMP check from monitor_read_password(), Markus Armbruster, 2015/03/12
- [Qemu-devel] [PATCH 3/5] monitor usb: Inline monitor_read_bdrv_key_start()'s first part, Markus Armbruster, 2015/03/12
- Re: [Qemu-devel] [PATCH 0/5] monitor usb: Fixes for encrypted images, Eric Blake, 2015/03/12
- Re: [Qemu-devel] [PATCH 0/5] monitor usb: Fixes for encrypted images, Gerd Hoffmann, 2015/03/17