[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] virtio_rpmsg: set DRIVER_OK before using device
|
From: |
Ohad Ben-Cohen |
|
Subject: |
Re: [Qemu-devel] [PATCH] virtio_rpmsg: set DRIVER_OK before using device |
|
Date: |
Wed, 11 Mar 2015 14:45:07 +0200 |
On Mon, Mar 9, 2015 at 10:41 AM, Michael S. Tsirkin <address@hidden> wrote:
> On Sat, Mar 07, 2015 at 08:06:56PM +0100, Michael S. Tsirkin wrote:
>> virtio spec requires that all drivers set DRIVER_OK
>> before using devices. While rpmsg isn't yet
>> included in the virtio 1 spec, previous spec versions
>> also required this.
>>
>> virtio rpmsg violates this rule: is calls kick
>> before setting DRIVER_OK.
>>
>> The fix isn't trivial since simply calling virtio_device_ready earlier
>> would mean we might get an interrupt in parallel with adding buffers.
>>
>> Instead, split kick out to prepare+notify calls. prepare before
>> virtio_device_ready - when we know we won't get interrupts. notify right
>> afterwards.
>>
>> Signed-off-by: Michael S. Tsirkin <address@hidden>
>> ---
>
> Ohad, can you review and ack pls?
Sure,
Acked-by: Ohad Ben-Cohen <address@hidden>