Re: [Qemu-devel] [PATCH 0/6] Clean up ISA dependencies so we make ISA optional to build

[Luiz Capitulino]

On Tue, 10 Mar 2015 15:20:29 +0100
"Michael S. Tsirkin" <address@hidden> wrote:

> On Fri, Mar 06, 2015 at 03:18:20PM +1100, David Gibson wrote:
> > At present, ISA bus support is always included in the build for all
> > targets.  However these days there are a number of targets that have
> > never had ISA, and even more where many of the individual machines
> > don't have ISA.
> > 
> > Unfortunately there are some awkward dependencies in the core code on
> > ISA, although b19c1c0 "isa: remove isa_mem_base variable" did already
> > remove one.
> > 
> > This series engages in some yak shaving to make the necessary
> > dependency cleanups, then make inclusion of ISA support optional.
> 
> For PC/PCI changes
> Acked-by: Michael S. Tsirkin <address@hidden>
> 
> 
> > 
> > Given the date, this is obviously aimed at qemu 2.4, not 2.3.
> 
> Looks like the date for 2.3 is unclear, so it might be
> ok to merge.
> 
> Who's taking this? Luiz? most changes are monitor-related.

I can take them, but the most important question for me is
who's reviewing them? I could do it, but not right now.

> 
> > David Gibson (6):
> >   Split serial-isa into its own config option
> >   Remove monitor.c dependency on CONFIG_I8259
> >   pc: Use MachineClass callbacks for "irq" and "pic" hmp commands
> >   target-ppc: Convert PReP to machine class
> >   prep: Use MachineClass callbacks for "irq" and "pic" hmp commands
> >   Allow ISA bus to be configured out
> > 
> >  default-configs/alpha-softmmu.mak     |  1 +
> >  default-configs/arm-softmmu.mak       |  1 +
> >  default-configs/i386-softmmu.mak      |  1 +
> >  default-configs/mips-softmmu.mak      |  1 +
> >  default-configs/mips64-softmmu.mak    |  1 +
> >  default-configs/mips64el-softmmu.mak  |  1 +
> >  default-configs/mipsel-softmmu.mak    |  1 +
> >  default-configs/moxie-softmmu.mak     |  2 ++
> >  default-configs/pci.mak               |  1 +
> >  default-configs/ppc-softmmu.mak       |  1 +
> >  default-configs/ppc64-softmmu.mak     |  1 +
> >  default-configs/ppcemb-softmmu.mak    |  1 +
> >  default-configs/sh4-softmmu.mak       |  1 +
> >  default-configs/sh4eb-softmmu.mak     |  1 +
> >  default-configs/sparc-softmmu.mak     |  1 +
> >  default-configs/sparc64-softmmu.mak   |  1 +
> >  default-configs/unicore32-softmmu.mak |  1 +
> >  default-configs/x86_64-softmmu.mak    |  1 +
> >  hw/char/Makefile.objs                 |  3 +-
> >  hw/i386/pc.c                          |  2 ++
> >  hw/intc/i8259.c                       |  4 +--
> >  hw/isa/Makefile.objs                  |  2 +-
> >  hw/ppc/prep.c                         | 32 ++++++++++++++------
> >  include/hw/boards.h                   |  2 ++
> >  include/hw/i386/pc.h                  |  4 +--
> >  monitor.c                             | 57 
> > ++++++++++++++++++++++++++---------
> >  26 files changed, 95 insertions(+), 30 deletions(-)
> > 
> > -- 
> > 2.1.0
>