[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/1] target-i386: Remove icc_bridge parameter fr
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 1/1] target-i386: Remove icc_bridge parameter from cpu_x86_create() |
Date: |
Tue, 10 Mar 2015 13:51:26 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
Am 10.03.2015 um 13:42 schrieb Eduardo Habkost:
> On Tue, Mar 10, 2015 at 12:50:07PM +0100, Andreas Färber wrote:
>> Am 05.03.2015 um 18:26 schrieb Eduardo Habkost:
>>> Instead of passing icc_bridge from the PC initialization code to
>>> cpu_x86_create(), make the PC initialization code attach the CPU to
>>> icc_bridge.
>>>
>>> The only difference here is that icc_bridge attachment will now be done
>>> after x86_cpu_parse_featurestr() is called. But this shouldn't make any
>>> difference, as property setters shouldn't depend on icc_bridge.
>>>
>>> Signed-off-by: Eduardo Habkost <address@hidden>
>>
>> Looks okay to me,
>>
>> Reviewed-by: Andreas Färber <address@hidden>
>>
>> But using this smaller patch will still make inlining pc_new_cpu(),
>> where you are moving it to, bigger diffstat-wise (WIP).
>
> I just see this it as a reason to not inline pc_new_cpu(). :)
Did you actually read my code? cpu_x86_create() does not allow in-place
initialization, in addition to doing the realized=true.
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)
Re: [Qemu-devel] [PATCH 1/1] target-i386: Remove icc_bridge parameter from cpu_x86_create(), Andreas Färber, 2015/03/10