[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] 9pfs-proxy: -retval vs errno vs -1
From: |
Aneesh Kumar K.V |
Subject: |
Re: [Qemu-devel] 9pfs-proxy: -retval vs errno vs -1 |
Date: |
Fri, 06 Mar 2015 11:22:56 +0530 |
User-agent: |
Notmuch/0.19+30~gd241a48 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) |
Michael Tokarev <address@hidden> writes:
> Another interesting tidbit is in hw/9pfs/virtio-9p-proxy.c.
>
> All filesystem methods use common v9fs_request() function,
> which returns -errno. So far so good.
>
> Now, *all* places which call this function, does this:
>
> retval = v9fs_request(...);
> if (retval < 0) {
> errno = -retval;
> }
> return retval;
>
> and *some* does this:
>
> retval = v9fs_request(...);
> if (retval < 0) {
> errno = -retval;
> retval = -1;
> }
> return retval;
We should be able to drop that retval = -1;
-aneesh