Re: [Qemu-devel] [PATCH v4 5/5] target-i386: Require APIC ID to be explicitly set before CPU realize

[Andreas Färber]

Am 04.03.2015 um 03:13 schrieb Eduardo Habkost:
> On softmuu, instead of setting APIC ID automatically when creating a
> X86CPU, require the property to be set before realizing the object
> (which is already done by the CPU creation code on PC).
> 
> Keep apic_id = 0 by default on *-user so it can simply create a new CPU
> object and realize it without extra steps (so target-i386 will be able
> to use cpu_generic_init() eventually).
> 
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
>  target-i386/cpu-qom.h |  2 +-
>  target-i386/cpu.c     | 10 ++++++++++
>  2 files changed, 11 insertions(+), 1 deletion(-)

Reviewed-by: Andreas Färber <address@hidden>

Thanks,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)