[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 08/47] cutils: refine strtol error handling in parse_
From: |
Michael Tokarev |
Subject: |
[Qemu-devel] [PULL 08/47] cutils: refine strtol error handling in parse_debug_env |
Date: |
Wed, 4 Mar 2015 20:06:25 +0300 |
From: Paolo Bonzini <address@hidden>
Avoid truncation of a 64-bit long to a 32-bit int, and check for errno
(especially ERANGE).
Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
util/cutils.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/util/cutils.c b/util/cutils.c
index dbe7412..9312e45 100644
--- a/util/cutils.c
+++ b/util/cutils.c
@@ -523,16 +523,17 @@ int parse_debug_env(const char *name, int max, int
initial)
{
char *debug_env = getenv(name);
char *inv = NULL;
- int debug;
+ long debug;
if (!debug_env) {
return initial;
}
+ errno = 0;
debug = strtol(debug_env, &inv, 10);
if (inv == debug_env) {
return initial;
}
- if (debug < 0 || debug > max) {
+ if (debug < 0 || debug > max || errno != 0) {
fprintf(stderr, "warning: %s not in [0, %d]", name, max);
return initial;
}
--
2.1.4
- Re: [Qemu-devel] [PULL 06/47] migration/rdma: clean up qemu_rdma_dest_init a bit, (continued)
- [Qemu-devel] [PULL 15/47] numa: remove superfluous '\n' around error_setg, Michael Tokarev, 2015/03/04
- [Qemu-devel] [PULL 37/47] e500: fix memory leak, Michael Tokarev, 2015/03/04
- [Qemu-devel] [PULL 25/47] xen: Remove xen_cmos_set_s3_resume(), Michael Tokarev, 2015/03/04
- [Qemu-devel] [PULL 32/47] milkymist.c: fix memory leak, Michael Tokarev, 2015/03/04
- [Qemu-devel] [PULL 03/47] xilinx_ethlite: Clean up after commit 2f991ad, Michael Tokarev, 2015/03/04
- [Qemu-devel] [PULL 27/47] qemu-char: add cyrillic characters 'numerosign' to VNC keysyms, Michael Tokarev, 2015/03/04
- [Qemu-devel] [PULL 47/47] 9pfs: remove useless return, Michael Tokarev, 2015/03/04
- [Qemu-devel] [PULL 46/47] gdbstub: avoid possible NULL pointer dereference, Michael Tokarev, 2015/03/04
- [Qemu-devel] [PULL 11/47] qmp-commands.hx: Fix several typos, Michael Tokarev, 2015/03/04
- [Qemu-devel] [PULL 08/47] cutils: refine strtol error handling in parse_debug_env,
Michael Tokarev <=
- [Qemu-devel] [PULL 28/47] qemu-char: add cyrillic key 'numerosign' to Russian keymap, Michael Tokarev, 2015/03/04
- [Qemu-devel] [PULL 16/47] Remove superfluous '\n' around error_report(), Michael Tokarev, 2015/03/04
- [Qemu-devel] [PULL 43/47] migration: Fix coding style (whitespace issues), Michael Tokarev, 2015/03/04
- [Qemu-devel] [PULL 13/47] a9gtimer: remove superfluous '\n' around error_setg, Michael Tokarev, 2015/03/04
- [Qemu-devel] [PULL 21/47] arm/digic_boards: Remove superfluous '\n' around error_report(), Michael Tokarev, 2015/03/04
- [Qemu-devel] [PULL 09/47] Add copyright and author after file split, Michael Tokarev, 2015/03/04
- [Qemu-devel] [PULL 30/47] sparc/leon3.c: fix memory leak, Michael Tokarev, 2015/03/04
- [Qemu-devel] [PULL 20/47] tpm: Remove superfluous '\n' around error_report(), Michael Tokarev, 2015/03/04
- [Qemu-devel] [PULL 26/47] qapi-schema: Fix SpiceChannel docs, Michael Tokarev, 2015/03/04
- [Qemu-devel] [PULL 42/47] oslib-posix: Fix compiler warning (-Wclobbered) and simplify the code, Michael Tokarev, 2015/03/04