[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] scsi-hd: fix property unset case
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH] scsi-hd: fix property unset case |
Date: |
Wed, 4 Mar 2015 15:12:29 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 04.03.2015 um 14:58 hat Max Reitz geschrieben:
> On 2015-03-04 at 07:23, Kevin Wolf wrote:
> >Am 04.03.2015 um 11:02 hat Ekaterina Tumanova geschrieben:
> >>commit "BlockConf: Call backend functions to detect geometry and
> >>blocksizes" causes a segmentation fault on the invalid configuration of
> >>a scsi device without a drive.
> >>
> >>Lets check for conf.blk before calling blkconf_blocksizes. The error
> >>will be handled later on in scsi_realize anyway.
> >>
> >>Reported-by: Max Reitz <address@hidden>
> >>Reviewed-by: Stefan Hajnoczi <address@hidden>
> >>Reviewed-by: Max Reitz <address@hidden>
> >>Signed-off-by: Ekaterina Tumanova <address@hidden>
> >Thanks, added the commit ID of the regression to the commit message, and
> >applied to the block branch.
>
> But that commit is not yet upstream, so the ID won't be stable. Are
> you planning to change it once it's merged?
Unless someone touches the pull request (which he shouldn't), the commit
ID is going to stay.
Kevin