[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 6/6 v4] linux-user/syscall.c: Switch all macros
|
From: |
Chen Gang S |
|
Subject: |
Re: [Qemu-devel] [PATCH 6/6 v4] linux-user/syscall.c: Switch all macros which are not defined in tilegx |
|
Date: |
Sat, 28 Feb 2015 07:06:32 +0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 |
On 02/28/2015 02:24 AM, Andreas Färber wrote:
> Am 22.02.2015 um 14:37 schrieb Chen Gang S:
>> For tilegx, several syscall macros are not supported, so switch them to
>> avoid building break.
>>
>> Signed-off-by: Chen Gang <address@hidden>
>> ---
>> linux-user/syscall.c | 50 +++++++++++++++++++++++++++++++++++++++++++++++++-
>> 1 file changed, 49 insertions(+), 1 deletion(-)
>
> LGTM,
>
> Reviewed-by: Andreas Färber <address@hidden>
>
> However I suggest "conditionalize syscalls" or "disable syscalls" over
> "switch ... macros/them".
>
OK, thanks. What you said above sounds reasonable to me.
Thanks.
--
Open, share, and attitude like air, water, and life which God blessed.
- [Qemu-devel] [PATCH 1/6 v4] target-tilegx: Firstly add to qemu with minimized features, (continued)
- [Qemu-devel] [PATCH 1/6 v4] target-tilegx: Firstly add to qemu with minimized features, Chen Gang S, 2015/02/22
- [Qemu-devel] [PATCH 3/6 v4] linux-user: tilegx: Add target features support within qemu, Chen Gang S, 2015/02/22
- [Qemu-devel] [PATCH 4/6 v4] linux-user: Support tilegx architecture in syscall, Chen Gang S, 2015/02/22
- [Qemu-devel] [PATCH 5/6 v4] linux-user: Support tilegx architecture in linux-user, Chen Gang S, 2015/02/22
- [Qemu-devel] [PATCH 6/6 v4] linux-user/syscall.c: Switch all macros which are not defined in tilegx, Chen Gang S, 2015/02/22
- Re: [Qemu-devel] [PATCH 0/6 v4] tilegx: Can load elf64 tilegx binary successfully for linux-user, Richard Henderson, 2015/02/22
- Re: [Qemu-devel] [PATCH 0/6 v4] tilegx: Can load elf64 tilegx binary successfully for linux-user, Bastian Koppelmann, 2015/02/22