Re: [Qemu-devel] [PATCH 4/6 v4] linux-user: Support tilegx architecture in syscall

[Andreas Färber]

Am 22.02.2015 um 14:36 schrieb Chen Gang S:
> Add tilegx architecture in "syscall_defs.h", all related features (ioctrl,
> and stat) are based on Linux kernel tilegx 64-bit implementation.
> 
> Signed-off-by: Chen Gang <address@hidden>
> ---
>  linux-user/syscall_defs.h | 38 ++++++++++++++++++++++++++++++++++----
>  1 file changed, 34 insertions(+), 4 deletions(-)
> 
> diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h
> index 9ed6de8..a0d9d77 100644
> --- a/linux-user/syscall_defs.h
> +++ b/linux-user/syscall_defs.h
[...]
> @@ -2312,7 +2340,9 @@ struct target_flock {
>  struct target_flock64 {
>       short  l_type;
>       short  l_whence;
> -#if defined(TARGET_PPC) || defined(TARGET_X86_64) || defined(TARGET_MIPS) || 
> defined(TARGET_SPARC) || defined(TARGET_HPPA) || defined (TARGET_MICROBLAZE)
> +#if defined(TARGET_PPC) || defined(TARGET_X86_64) || defined(TARGET_MIPS) || 
> \
> +    defined(TARGET_SPARC) || defined(TARGET_HPPA) \
> +    || defined(TARGET_MICROBLAZE) || defined(TARGET_TILEGX)

Nit: You're inconsistent as to where you're placing ||.

Regards,
Andreas

>          int __pad;
>  #endif
>       unsigned long long l_start;
> 


-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)