[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RfC PATCH 06/15] virtio-gpu/2d: add virtio gpu core co
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [RfC PATCH 06/15] virtio-gpu/2d: add virtio gpu core code |
Date: |
Fri, 27 Feb 2015 15:31:04 +0100 |
> >>> + if (t2d.offset || t2d.r.x || t2d.r.y ||
> >>> + t2d.r.width != pixman_image_get_width(res->image)) {
> >> Will this work with stride != t2d.r.width * bpp?
> > Those cases should take the if branch above and loop over all lines to
> > handle it correctly.
>
> Exactly, but it looks like to me that it doesn't (at least not always).
Ah, you mean we should better check something like
t2d.r.width * bpp != pixman_image_get_stride() ?
That should check exactly the same thing as we never create resources
with extra padding where width * bpp != stride.
cheers,
Gerd
- [Qemu-devel] [RfC PATCH 07/15] virtio-gpu-pci: add virtio pci support, (continued)
[Qemu-devel] [RfC PATCH 05/15] virtio-gpu/2d: add hardware spec include file, Gerd Hoffmann, 2015/02/23
[Qemu-devel] [RfC PATCH 13/15] virtio-vga: add vgabios binary, Gerd Hoffmann, 2015/02/23
[Qemu-devel] [RfC PATCH 01/15] virtio-pci: add flags to enable/disable legacy/modern, Gerd Hoffmann, 2015/02/23
Re: [Qemu-devel] [RfC PATCH 00/15] virtio-gpu:, Max Reitz, 2015/02/26