[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] sheepdog: Fix misleading error messages in sd_s
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH] sheepdog: Fix misleading error messages in sd_snapshot_create() |
|
Date: |
Fri, 27 Feb 2015 13:56:01 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Markus Armbruster <address@hidden> writes:
> If do_sd_create() fails, it first reports the error returned, then
> reports a another one with strerror(errno). errno is meaningless at
> that point.
>
> Report just one error combining the valid information from both
> messages.
>
> Reported-by: Eric Blake <address@hidden>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> Applies on top of my "[PATCH v2 00/10] Clean up around
> error_get_pretty(), qerror_report_err()", but rebasing to master would
> be trivial.
Applies cleanly on master now. Maintainers, please apply.