[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] sheepdog: fix confused return values
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] sheepdog: fix confused return values |
|
Date: |
Fri, 27 Feb 2015 11:29:53 +0000 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, Feb 18, 2015 at 11:57:55AM +0800, Liu Yuan wrote:
> From: Liu Yuan <address@hidden>
>
> These functions mix up -1 and -errno in return values and would might cause
> trouble error handling in the call chain.
>
> This patch let them return -errno and add some comments.
>
> Cc: address@hidden
> Cc: Markus Armbruster <address@hidden>
> Cc: Kevin Wolf <address@hidden>
> Cc: Stefan Hajnoczi <address@hidden>
> Reported-by: Markus Armbruster <address@hidden>
> Signed-off-by: Liu Yuan <address@hidden>
> ---
> v2:
> - use socket_error() instead of errno
>
> block/sheepdog.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
pgpdQq11dxRp3.pgp
Description: PGP signature