[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hmp: info spice: Show string channel name
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] hmp: info spice: Show string channel name |
Date: |
Thu, 26 Feb 2015 13:48:22 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 02/26/2015 12:02 PM, Cole Robinson wrote:
> Useful for debugging.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=822418
> Signed-off-by: Cole Robinson <address@hidden>
> ---
> hmp.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/hmp.c b/hmp.c
> index 735097c..93fd5cd 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -545,6 +545,11 @@ void hmp_info_spice(Monitor *mon, const QDict *qdict)
> {
> SpiceChannelList *chan;
> SpiceInfo *info;
> + const char *channel_name;
> + /* String representations of SPICE_CHANNEL_* enum */
> + const char * const channel_names[] = {"main", "display", "input",
> "cursor",
> + "playback", "record", "tunnel", "smartcard", "usbredir", "port",
> + "webdav"};
>
Hmm. I wonder if we should have a QAPI enum for this, instead of
open-coding it here. But as this is already a strict improvement,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature