[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] vfio: allow to disable MMAP per device with -x-
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] vfio: allow to disable MMAP per device with -x-mmap=off option |
Date: |
Tue, 24 Feb 2015 20:04:44 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 02/24/2015 02:53 PM, Alex Williamson wrote:
>>
>> Naming it 'x-mmap' implies it is experimental and may be removed
>> someday. Is there any reason why you are not proposing it as a
>> permanent knob?
>
> I actually suggested the x- prefix to Samuel because I don't think this
> is a mode that we want to officially support. It's useful for enabling
> tracing, but it's possible that doing this will break timing sensitive
> devices. I therefore don't really want to put it at the fingertips of
> the average user.
Works for me :)
> If we have a reason to call it supported at some
> point later, we can always change it. Thanks,
Yep, that's always an option. Easier to make something stable later
when it proved worthwhile, than it is to regret making it stable now.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature