Re: [Qemu-devel] [PATCH v4 00/10] cpu: add device_add foo-x86_64-cpu support

[Andreas Färber]

Hi Gu,

Am 24.02.2015 um 02:25 schrieb Gu Zheng:
> The issues you commented in the previous version have been fixed in this one.

What I have repeatedly rejected is "device_add foo-x86_64-cpu". This is
still in 00/10 and 09/10. Most of the actual changes however do look to
be going in the right direction of making 'realize' work as expected for
foo-x86_64-cpu.

As for the socket-based device_add I mentioned, I had pushed a work
branch qom-cpu-x86 and had some off-list discussions for some of the
other architectures but did not submit it as an RFC yet. What I am still
working on is dynamic properties to allocate cores (threads TBD) for
"device_add x86_64-cpu-socket,cores=n".

> Could you please help to review it?

Will get to it Friday earliest.

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)