Re: [Qemu-devel] [PATCH v5 13/16] spapr_pci: populate DRC dt entries for PHBs

[David Gibson]

On Mon, Feb 16, 2015 at 08:27:49AM -0600, Michael Roth wrote:
> Reserve 32 entries of type PCI in each PHB's initial FDT. This

I find this description odd.  It's not reallky reserving anything,
just publishing the DRCs you already created in the FDT.

I wonder if this should be merged with the previous patch.

> advertises to guests that each PHB is DR-capable device with
> physical hotpluggable slots. This is necessary for allowing
> hotplugging of devices to it later via bus rescan or guest rpaphp
> hotplug module.
> 
> Signed-off-by: Michael Roth <address@hidden>

But, it looks correct.

Reviewed-by: David Gibson <address@hidden>

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

pgpcA8qRO60XH.pgp
Description: PGP signature