[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 01/10] spapr_iommu: Disable in-kernel IOMMU tables f
From: |
Alexey Kardashevskiy |
Subject: |
[Qemu-devel] [PATCH 01/10] spapr_iommu: Disable in-kernel IOMMU tables for >4GB windows |
Date: |
Mon, 23 Feb 2015 19:33:51 +1100 |
The existing KVM_CREATE_SPAPR_TCE ioctl only support 4G windows max as
the window size parameter to the kernel ioctl() is 32-bit so
there's no way of expressing a TCE window > 4GB.
We are going to add huge DMA windows support so this will create small
window and unexpectedly fail later.
This disables KVM_CREATE_SPAPR_TCE for windows bigger that 4GB.
Signed-off-by: Alexey Kardashevskiy <address@hidden>
Reviewed-by: David Gibson <address@hidden>
---
Changes:
v3:
* fixed commit log
* added cast to uint64_t
---
hw/ppc/spapr_iommu.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/ppc/spapr_iommu.c b/hw/ppc/spapr_iommu.c
index f9f85c5..4de6ba1 100644
--- a/hw/ppc/spapr_iommu.c
+++ b/hw/ppc/spapr_iommu.c
@@ -125,11 +125,11 @@ static MemoryRegionIOMMUOps spapr_iommu_ops = {
static int spapr_tce_table_realize(DeviceState *dev)
{
sPAPRTCETable *tcet = SPAPR_TCE_TABLE(dev);
+ uint64_t window_size = (uint64_t)tcet->nb_table << tcet->page_shift;
- if (kvm_enabled()) {
+ if (kvm_enabled() && !(window_size >> 32)) {
tcet->table = kvmppc_create_spapr_tce(tcet->liobn,
- tcet->nb_table <<
- tcet->page_shift,
+ window_size,
&tcet->fd,
tcet->vfio_accel);
}
--
2.0.0
- [Qemu-devel] [PATCH 00/10] spapr: Small patches to prepare for Dynamic DMA windows, Alexey Kardashevskiy, 2015/02/23
- [Qemu-devel] [PATCH 02/10] spapr_iommu: Make H_PUT_TCE_INDIRECT endian-safe, Alexey Kardashevskiy, 2015/02/23
- [Qemu-devel] [PATCH 04/10] spapr_vio: Introduce a liobn number generating macros, Alexey Kardashevskiy, 2015/02/23
- [Qemu-devel] [PATCH 01/10] spapr_iommu: Disable in-kernel IOMMU tables for >4GB windows,
Alexey Kardashevskiy <=
- [Qemu-devel] [PATCH 03/10] spapr_pci: Introduce a liobn number generating macros, Alexey Kardashevskiy, 2015/02/23
- [Qemu-devel] [PATCH 08/10] spapr_iommu: Make spapr_tce_find_by_liobn() public, Alexey Kardashevskiy, 2015/02/23
- [Qemu-devel] [PATCH 07/10] spapr_pci: Make find_phb()/find_dev() public, Alexey Kardashevskiy, 2015/02/23
- [Qemu-devel] [PATCH 06/10] spapr_iommu: Add separate trace points for PCI DMA operations, Alexey Kardashevskiy, 2015/02/23
- [Qemu-devel] [PATCH 09/10] spapr_pci: Rework device-tree rendering, Alexey Kardashevskiy, 2015/02/23
- [Qemu-devel] [PATCH 05/10] spapr_pci: Define default DMA window size as a macro, Alexey Kardashevskiy, 2015/02/23
- [Qemu-devel] [PATCH 10/10] spapr_iommu: Give unique QOM name to TCE table, Alexey Kardashevskiy, 2015/02/23