[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v2 13/15] cpu-model/s390: Add processor prop
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [RFC PATCH v2 13/15] cpu-model/s390: Add processor property routines |
Date: |
Fri, 20 Feb 2015 16:41:49 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
Am 20.02.2015 um 16:32 schrieb Michael Mueller:
> On Fri, 20 Feb 2015 15:03:30 +0100
> Alexander Graf <address@hidden> wrote:
>
>>>
>>> - s390_get_proceccor_props()
>>> - s390_set_proceccor_props()
>>>
>>> They can be used to request or retrieve processor related information from
>>> an accelerator.
>>> That information comprises the cpu identifier, the ICB value and the
>>> facility lists.
>>>
>>> Signed-off-by: Michael Mueller <address@hidden>
>>
>> Hrm, I still seem to miss the point of this interface. What do you need
>> it for?
>
> These functions make the internal s390 cpu model API independent from a
> specific accelerator:
>
> int s390_set_processor_props(S390ProcessorProps *prop)
> {
> if (kvm_enabled()) {
> return kvm_s390_set_processor_props(prop);
> }
> return -ENOSYS;
> }
>
> It's called by:
>
> s390_select_cpu_model(const char *model)
>
> which is itself called by:
>
> S390CPU *cpu_s390x_init(const char *cpu_model)
> {
> S390CPU *cpu;
>
> cpu = S390_CPU(object_new(s390_select_cpu_model(cpu_model)));
>
> object_property_set_bool(OBJECT(cpu), true, "realized", NULL);
>
> return cpu;
> }
>
> So above s390_set/get_processor_props() the code is accelerator independent.
Can't you just implement the class-level name-to-ObjectClass callback
that other CPUs have grown for the above use case?
Also a general comment: cpu-model/ is not an existing directory nor one
you add, so please use "target-s390x: Add foo to S390CPU" or so.
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)
- Re: [Qemu-devel] [RFC PATCH v2 10/15] cpu-model/s390: Add cpu class initialization routines, (continued)
Re: [Qemu-devel] [RFC PATCH v2 10/15] cpu-model/s390: Add cpu class initialization routines, Richard Henderson, 2015/02/20
[Qemu-devel] [RFC PATCH v2 13/15] cpu-model/s390: Add processor property routines, Michael Mueller, 2015/02/17
Re: [Qemu-devel] [RFC PATCH v2 13/15] cpu-model/s390: Add processor property routines, Michael Mueller, 2015/02/20
Re: [Qemu-devel] [RFC PATCH v2 13/15] cpu-model/s390: Add processor property routines, Alexander Graf, 2015/02/20
Re: [Qemu-devel] [RFC PATCH v2 13/15] cpu-model/s390: Add processor property routines, Michael Mueller, 2015/02/20