Re: [Qemu-devel] [PATCH RFC v3 07/14] qapi: add dirty-bitmaps migration capability

[John Snow]

On 02/18/2015 09:00 AM, Vladimir Sementsov-Ogievskiy wrote:
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
>   include/migration/migration.h | 1 +
>   migration/migration.c         | 9 +++++++++
>   qapi-schema.json              | 5 ++++-
>   3 files changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/include/migration/migration.h b/include/migration/migration.h
> index f37348b..719875d 100644
> --- a/include/migration/migration.h
> +++ b/include/migration/migration.h
> @@ -145,6 +145,7 @@ void migrate_del_blocker(Error *reason);
>
>   bool migrate_rdma_pin_all(void);
>   bool migrate_zero_blocks(void);
> +bool migrate_dirty_bitmaps(void);
>
>   bool migrate_auto_converge(void);
>
> diff --git a/migration/migration.c b/migration/migration.c
> index b3adbc6..68e7478 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -567,6 +567,15 @@ bool migrate_zero_blocks(void)
>       return s->enabled_capabilities[MIGRATION_CAPABILITY_ZERO_BLOCKS];
>   }
>
> +bool migrate_dirty_bitmaps(void)
> +{
> +    MigrationState *s;
> +
> +    s = migrate_get_current();
> +
> +    return s->enabled_capabilities[MIGRATION_CAPABILITY_DIRTY_BITMAPS];
> +}
> +
>   int migrate_use_xbzrle(void)
>   {
>       MigrationState *s;
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 0c31203..70b54ab 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -494,10 +494,13 @@
>   # @auto-converge: If enabled, QEMU will automatically throttle down the guest
>   #          to speed up convergence of RAM migration. (since 1.6)
>   #
> +# @dirty-bitmaps: If enabled, QEMU will migrate named dirty bitmaps. (since 
> 2.3)
> +#
>   # Since: 1.2
>   ##
>   { 'enum': 'MigrationCapability',
> -  'data': ['xbzrle', 'rdma-pin-all', 'auto-converge', 'zero-blocks'] }
> +  'data': ['xbzrle', 'rdma-pin-all', 'auto-converge', 'zero-blocks',
> +           'dirty-bitmaps'] }
>
>   ##
>   # @MigrationCapabilityStatus

Reviewed-by: John Snow <address@hidden>