Re: [Qemu-devel] [PATCH v3 11/17] virtio-serial: switch to standard-headers

[Thomas Huth]

On Wed, 18 Feb 2015 15:55:54 +0100
"Michael S. Tsirkin" <address@hidden> wrote:

> On Wed, Feb 18, 2015 at 03:34:13PM +0100, Thomas Huth wrote:
> > On Mon, 16 Feb 2015 22:36:26 +0100
> > "Michael S. Tsirkin" <address@hidden> wrote:
...
> > > diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c
> > > index 47fbb34..a2bac9b 100644
> > > --- a/hw/char/virtio-serial-bus.c
> > > +++ b/hw/char/virtio-serial-bus.c
> > > @@ -18,6 +18,7 @@
> > >   * GNU GPL, version 2 or (at your option) any later version.
> > >   */
> > > 
> > > +#include "standard-headers/linux/virtio_ids.h"
> > 
> > Could you omit this include? Later in virtio-serial-bus.c, the code
> > includes hw/virtio/virtio-serial.h, which in turn includes
> > standard-headers/linux/virtio_console.h - and that one already includes
> > the ids.h file. So I think it should work without the above change, too.
> > 
> >  Thomas
> 
> Yes but it's generally not a good idea to depend on headers
> including each other.
 
But as far as I can see, you also did not do this change in your other
patches of this series, so this seems a little bit inconsequent (e.g.
virtio-blk.c depends on VIRTIO_ID_BLOCK, but you did not include the
virtio_ids.h header there).

 Thomas