[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 04/24] qcow2: Only return status from qcow2_g
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v6 04/24] qcow2: Only return status from qcow2_get_refcount |
Date: |
Tue, 17 Feb 2015 09:56:18 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 02/17/2015 03:19 AM, Kevin Wolf wrote:
>> if (num_fixed) {
>> ret = update_refcount(bs, i << s->cluster_bits, 1,
>> - refcount2 - refcount1,
>> + (int)refcount2 - (int)refcount1,
>> QCOW2_DISCARD_ALWAYS);
>> if (ret >= 0) {
>> (*num_fixed)++;
>
> Wouldn't both refcounts be promoted to int anyway, even without a cast?
> But then, being explicit probably can't hurt either.
But it all goes away in the next patch that switches to uint64_t, so I
don't mind the temporary ugliness.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v6 00/24] qcow2: Support refcount orders != 4, Max Reitz, 2015/02/10
- [Qemu-devel] [PATCH v6 01/24] qcow2: Add two new fields to BDRVQcowState, Max Reitz, 2015/02/10
- [Qemu-devel] [PATCH v6 03/24] qcow2: Do not return new value after refcount update, Max Reitz, 2015/02/10
- [Qemu-devel] [PATCH v6 02/24] qcow2: Add refcount_bits to format-specific info, Max Reitz, 2015/02/10
- [Qemu-devel] [PATCH v6 04/24] qcow2: Only return status from qcow2_get_refcount, Max Reitz, 2015/02/10
- [Qemu-devel] [PATCH v6 05/24] qcow2: Use unsigned addend for update_refcount(), Max Reitz, 2015/02/10
- [Qemu-devel] [PATCH v6 06/24] qcow2: Use 64 bits for refcount values, Max Reitz, 2015/02/10
- [Qemu-devel] [PATCH v6 10/24] qcow2: Open images with refcount order != 4, Max Reitz, 2015/02/10
- [Qemu-devel] [PATCH v6 08/24] qcow2: Helper function for refcount modification, Max Reitz, 2015/02/10
- [Qemu-devel] [PATCH v6 12/24] qcow2: Use symbolic macros in qcow2_amend_options, Max Reitz, 2015/02/10
- [Qemu-devel] [PATCH v6 07/24] qcow2: Helper for refcount array reallocation, Max Reitz, 2015/02/10